Rounding error on vshop lets you jump to head of line

Bug: Rounding error on vshop lets you jump to head of line

IGN: Pluto258

Date of Bug: reporting 10/25/17

Summary of Bug: There is a rounding error with vshop that lets you jump to the head of the line with the same price as the cheapest person. Example player A has signs up on /vshop for 34. Player B does "/sell 10 sign 33.999" this will place player B signs in the front of the line for 34. I know there used to be a hiccup with vshop where if you posted for the same price you had about a 1% chance of accidentally being placed in front. Recently Blakek13 has been jumping the line multiple times a day, way too much for the accidental placement.

Evidence of Bug:

Additional information: Just today he is at the front of the line with the same lowest price in sign, wheat, jackolantern, potato, paper and sunflower. He and i have been battling back and forth on vshop recently. I repriced my sign and wheat prices before deciding to fill a bug report. i left the rest. I was on a little after 10pm est last night and posted some stuff to vshop. I noticed blakek13's vshop prices at around 7:30 am est this morning.

 

What do you mean "jump to the front of line?"

 

If i understand how vshop works, when you post items at the same price as is already there, you go behind the person already selling, so their items sell first. If you want to move ahead of them, you have to post at a lower price. As I mentioned, there is a hiccup where less than 1% of the time, posting at the same price puts the newer seller ahead of the seller already there, but it is very rare.
Using the rounding error, you can post new items at the same price as someone already on vshop, but be placed ahead of them in the queue, thus getting to sell your items first for the exact same price as someone who was already selling.

 

well if someone was selling signs for 40 meebles and you put up signs for 39.999 meebles than that means that the system works because it puts the lower price first. however the view-able price is rounded but it may not sell for 40 it sells for 39.999.

 

Except it sells the newer ones for 40 instead of 39.999. That's how you can "jump to the head of the line" and still get the same price as existing sellers. yes i tested this.

 

tbh I used to do this a lot I don't think it's a bug at all. I would do signs for 39.95 in your case to make SURE your ahead, or make a wood farm to drastically lower the price (signs are worth more like 4 than 40 anyways)
just because someone outsmarts you doesn't mean the system is broken

 

FamousZamos, I think you are missing my point.

I have no problem with people posting stuff for less than me, that's how vshop works.

What I feel is wrong here is that by taking advantage of the way the prices are rounded, and posting for a price that can't be charged and/or displayed, the other player is moving ahead of me in the queue for the EXACT same price as me, which in not the way the vshop is supposed to work.
If it's not a bug, it could still be fixed by a change. Move the lines of code that decide where in the queue this posting of items belongs to the very end of the subroutine, so all other calculations and moving of any existing items of this type, are taken care of before hand, and it gets placed in the queue in the correct spot based on the existing rules.

 

if you want a solution, removing thousandth-place digits from vshop should work, so only usuable values are shown tbh it's not hard

 

Famous - yea, that dawned on me about 1/2 an hour after my last reply. Much simpler solution.

 

I'll take a look soon, I have no idea at the moment.

 

Thank you both for your attention on this matter.

Lordinateur - great gif. my son who just took Calculus cracked up when he saw it.

 

I think this should be a quick fix, just take the place for input and immediately round the float to the hundredths or return an error if a number beyond hundredths is used. This may not be the largest problem ever, but it's a quick fix for a definite problem.

 

Fixed